Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ibm-required-array-properties-in-response): avoid errors in allOf elements w/o required keyword #692

Open
wants to merge 1 commit into
base: bump-deps
Choose a base branch
from

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Nov 4, 2024

PR summary

Fixes #690
This PR fixes the issue by bypassing our error checks for
any allOf element schema that does not include a 'required' field.

PR Checklist

General checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Dependencies have been updated as needed
  • .secrets.baseline updated as needed?

Checklist for adding a new validation rule:

  • Added new validation rule definition (packages/ruleset/src/rules/*.js, index.js)
  • If necessary, added new validation rule implementation (packages/ruleset/src/functions/*.js, updated index.js)
  • Added new rule to default configuration (packages/ruleset/src/ibm-oas.js)
  • Added tests for new rule (packages/ruleset/test/*.test.js)
  • Added docs for new rule (docs/ibm-cloud-rules.md)

… elements w/o required keyword

Signed-off-by: Phil Adams <[email protected]>
@padamstx padamstx self-assigned this Nov 4, 2024
@padamstx padamstx requested a review from dpopp07 November 4, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant