New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for MenuService #1217

Open

Agaba-derrick wants to merge 14 commits into I-TECH-UW:develop from Agaba-derrick:Add-Menu-service-Test

Contributor

Agaba-derrick commented Aug 2, 2024

Pull Requests Requirements

The PR title includes a brief description of the work done, including the
Issue number if applicable.
The PR includes a video showing the changes for the work done.
The PR title follows conventional commit label standards.
The changes confirm the OpenElis Global x3 Styleguide and design
documentation.
The changes include tests or are validated by existing tests.
I have read and agree to the Contributing Guidelines of this project.

Summary

Screenshots

Related Issue

Add intergration Tests for menu #1216

Other

@mozzy11 kindly review this


          Add tests for MenuService

2cdcfca

mherman22 reviewed

View reviewed changes

Contributor

mherman22 left a comment

@Agaba-derrick please run mvn spotless:apply to fix the formatting of this PR and fix the failing build


          Add-More-menu-service-tests

954f280

Contributor Author

Agaba-derrick commented Aug 3, 2024

Agaba-derrick requested a review from mherman22

August 3, 2024 19:22

mherman22 suggested changes

View reviewed changes

Contributor

mherman22 left a comment •

edited

Loading

@Agaba-derrick try to align your test methods to some of the suggestions i have added otherwise this looks fine already

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved


          fix-Assertions

ac5e6a2

Agaba-derrick requested a review from mherman22

August 4, 2024 16:02

mherman22 approved these changes

View reviewed changes

Contributor

mherman22 left a comment

LGTM 👍🏿

mozzy11 reviewed

View reviewed changes

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved

mozzy11 requested changes

View reviewed changes

Collaborator

mozzy11 left a comment

Thanks @Agaba-derrick for adding more Intergration tests for the Menu Service,
However am seeing alot of added test which are simply units test and not Integration TEsts for the Menu service.
Can you remove those

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved

Agaba-derrick added 3 commits

August 5, 2024 16:09


          Menu-service-tests-fix

5c5a40a


          fix-more tests

40b11ed


          remove-elementId-test

f8f7235

Agaba-derrick requested a review from mozzy11

August 5, 2024 13:32

fix

93a4e68

Contributor Author

Agaba-derrick commented Aug 5, 2024

@mozzy11 i notice that even after running maven spotless:apply the CI builds still fail !!

Agaba-derrick added 2 commits

August 8, 2024 21:04


          Merge branch 'develop' into Add-Menu-service-Test

0b31201


          fix Menu-service-Tests

91ccc04

mozzy11 reviewed

View reviewed changes

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved

mozzy11 requested changes

View reviewed changes

Collaborator

mozzy11 left a comment

Thanks @Agaba-derrick for the PR.
Can you remove all the methods that dont test the MenuService ??

src/test/java/org/openelisglobal/menu/MenuServiceTest.java Outdated Show resolved Hide resolved

Agaba-derrick added 3 commits

August 22, 2024 19:08


          remove-spaces

2330dd0


          fix-menu-tests

e15370f


          Merge branch 'develop' into Add-Menu-service-Test

1aa65b4

Agaba-derrick requested a review from mozzy11

August 23, 2024 10:19

Contributor Author

Agaba-derrick commented Aug 28, 2024

Thanks @Agaba-derrick for the PR. Can you remove all the methods that dont test the MenuService ??
yes sure

github-actions bot commented Oct 11, 2024

👋 Hi, @Agaba-derrick,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions bot added the merge conflict label

mozzy11 added 2 commits

October 17, 2024 22:02


          Merge branch 'develop' into Add-Menu-service-Test

e118a02


          fix format

544106b

github-actions bot removed the merge conflict label

github-actions bot commented Oct 29, 2024

👋 Hi, @Agaba-derrick,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions bot added the merge conflict label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels