Convert moment to luxon #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sofacosta
commented
Jan 12, 2023
src/TextHelpers.js
Outdated
| @@ -186,5 +194,5 @@ export const formatDatePair = (startTime, endTime, returnAsObj) => { | |||
| } | |||
|
|
|||
| export function isDateInTheFuture (date) { | |||
| return moment(date).isAfter(moment()) | |||
| return DateTime.fromMillis(date).isAfter(DateTime.now()) | |||
There was a problem hiding this comment.
This function previously was able to accept Dates in many different formats, but is now ONLY capable of accepting timestamps.
There was a problem hiding this comment.
there's no way to create a DateTime from different formats? lets just make sure this isn't a problem where we use it of course
Sofacosta
commented
Jan 12, 2023
| const d2 = moment.tz(d1, 'Etc/GMT').hour(21) | ||
| const d3 = moment.tz(d2, 'Etc/GMT').day(2) | ||
| const d4 = moment.tz(d3, 'Etc/GMT').month(2) | ||
| const d5 = moment.tz(d3, 'Etc/GMT').year(2050) |
There was a problem hiding this comment.
This way of using the tz function isn't directly replicable with luxon.
Sofacosta
commented
Jan 12, 2023
| @@ -1,11 +1,17 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
|
|
|||
| exports[`formatDatePair displays differences of dates 1`] = `"Mon, Feb 4, 2019 at 11:41AM MST"`; | |||
| exports[`formatDatePair displays differences of dates 1`] = `"Mon, Feb 4, 2019, 11:41 AM CST"`; | |||
There was a problem hiding this comment.
we lose the "at", but we gain internationalization.
There was a problem hiding this comment.
maybe we use @ instead of comma?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.