Convert errorHandlers to TypeScript #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemmerle
requested review from
brandenrodgers,
camden11 and
joe-yeager
as code owners
joe-yeager
reviewed
Nov 20, 2024
camden11
reviewed
Nov 20, 2024
There was a problem hiding this comment.
I think a good rule to follow in these Typescript PRs is to never cast unless you absolutely have to - 99% of the time there's a better way and not letting yourself cast will force you to find it! I'm always around if you have any questions about that kind of stuff.
Also, it looks like your commits from your last PR got included here, i'm assuming this is because we are now squashing commits and you need to rebase off main (unfortunately i haven't worked with squash commits in a bit and I forget exactly how to do that)
kemmerle
force-pushed
the
convert/ts-3
branch
from
a80e1d6
to
1af6ee7
Compare
camden11
reviewed
Nov 21, 2024
brandenrodgers
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
I've converted the files located in the
lib/errorHandlersfolder.Problem with eslint as been addressed 👍
TODO
Who to Notify
@brandenrodgers @camden11 @joe-yeager