Modify hs create module command to correspondence to content_types (Previously host_template_types)
#1225
Conversation
kotto5
requested review from
brandenrodgers,
camden11,
kemmerle and
joe-yeager
as code owners
|
@graysky @also @timmfin @bbeaudreault |
|
@kotto5 - RE: this comment "After version may have problem about UI" and what to do here. I would be fine with this update moving through independently of UI updates to make this better (for the short term). We can discuss the proper pattern for long-form option lists over here on our side and make sure it is consistent across the commands. |
lib/prompts/createModulePrompt.ts
Outdated
| @@ -30,10 +30,18 @@ const CONTENT_TYPES_PROMPT = { | |||
| message: i18n(`${i18nKey}.selectContentType`), | |||
| default: ['PAGE'], | |||
There was a problem hiding this comment.
Hi @kotto5 - one quick note that we should update the default here to point to the ANY option instead to support this change
There was a problem hiding this comment.
Thanks for review @TanyaScales
I fixed it based on your point, and I'm glad to see that the UI thing is not a problem either.
Hope you will check the fixes.
There was a problem hiding this comment.
@TanyaScales
How do I ask other reviewers for a review after I have been approved by you?
There was a problem hiding this comment.
Hey @kotto5 - I brought this up internally with some of the others already tagged on this issue to discuss when it should be merged and released. So you should actually be all set here. We'll take care of the merge when we're ready for it to be lined up in the queue to go out.
Thanks for your contribution.
Modify choices for content_types
kotto5
force-pushed
the
modify_module_create_checkbox
branch
from
e17ba1e
to
c4eb494
Compare
…teModulePrompt.ts
Description and Context
Modify
hs create modulecommand's content_type checkbox to choose value for content_types.Previously, you could choose a value for host_template_types.
It causes an error when you upload modules.
#1224
Screenshots
Before
After
After version may have problem about UI. Choices are too many to choose and to display at once so you have to scroll to see all choices. It can make confuse user who create modules.
TODO
Who to Notify