Add Routing example #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmatto
reviewed
Jun 11, 2024
Ah, yes. Totally forgot about including that like we discussed. I will get that added 👍 |
bmatto
reviewed
Jun 11, 2024
|
|
||
| export const Component = () => { | ||
| return ( | ||
| <div> |
There was a problem hiding this comment.
Just a curiosity, is this DIV needed here?
There was a problem hiding this comment.
Nope! Just a little leftover cruft 😅
|
@bmatto updated to showcase dynamic routes and added a readme calling out the important bits. Let me know what you think! |
bmatto
reviewed
Jun 17, 2024
| @@ -0,0 +1,61 @@ | |||
| # Routing | |||
| With CMS React, you can use popular routing libraries like React-Router to enable SPA-style routing within your CMS website. The Pokedex example in this directory showcases how to set up SPA routing in your own project using React-Router. This documentation will walk through key aspects of our example, but for more information on React-Router, please visit their [docs](https://reactrouter.com/en/main). | |||
There was a problem hiding this comment.
This all looks good, the only thing I think is missing is the usage of [:dynamic-slug] within the actual page to enable the SPA routing on the server.
There was a problem hiding this comment.
Addressed 299d776
bmatto
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an example of using react-router for a cms-react project.
Screenshots