No more noisy fans! #4
Conversation
Changed the controller to dynamically update the speeds based the temperature
fancontrol.py
Outdated
|
|
||
| time.sleep(SLEEP_INTERVAL) | ||
| time.sleep(SLEEP_INTERVAL) |
There was a problem hiding this comment.
I see here I didn't leave a line at the end of the code and its raised an error. What is the reason for needing a new line at the end of the code?
There was a problem hiding this comment.
This is a standard for most programming languages. It helps ensure proper parsing on all platforms. Here's one explanation: https://unix.stackexchange.com/questions/18743/whats-the-point-in-adding-a-new-line-to-the-end-of-a-file
That change is showing. The icon at the end says no-new-line, that is missing from the newest version.
|
|
Is this configurable, and off by default? As some fans won't work well with this feature. |
There was a problem hiding this comment.
I like this a lot, but it would be good to know if this will work for all fans. I saw a comment suggesting it wouldn't. If that's the case, we should add this as a feature, but leave it disabled by default.
Thanks for contributing btw, and good work. Sorry for the delay!
fancontrol.py
Outdated
| SLEEP_INTERVAL = 5 # (seconds) How often we check the core temperature. | ||
| GPIO_PIN = 17 # Which GPIO pin you're using to control the fan. | ||
| SLEEP_INTERVAL = 3 # (seconds) How often we check the core temperature. | ||
| GPIO_PIN = 18 # Which GPIO pin you're using to control the fan. |
There was a problem hiding this comment.
Does the pin need to change here?
There was a problem hiding this comment.
I believe it does as not all GPIO pins are PWM enabled.
There was a problem hiding this comment.
The RPI manual will tell you which of the pins are PWM enabled. They aren't all but there are a few
|
Good point- I'm not sure if any fans would be affected I followed your tutorial and it worked okay. I'll go back and add the option though! |
|
There are some fans that need a "kick" to start using 0.5 values on PWM. I think a good approach would be to set the output to |
|
Hey, I finally set up a new pi and needed to use this again- I left an option to choose between using threshold and variable speeds. |
|
Hey, anything I need to add or fix to get this approved? |
The program now ramps up the speed of your fan as and when it needs!
This drastically reduces the noise as the fan seldom ramps up past 60%.
The OUTPUTS and TEMPS variables are meant to be tweaked according to your wants and needs.
Its my first time contributing to anybody else's code so all criticism is welcome :)