This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
feat(#664): update react to v17, and typescript to match #683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #664.
-- currently blocked by npm run build which uses tsdx (tsdx uses typescript v3, and sends error when seeing that we used tsConfig.compilerOptions = 'react-jsx' which is a typescript 4 compatible option (react-jsx used over prev option to implement react 17 jsx-transform)
Changes proposed in this pull request:
update react & react-dom to v17
update typescript to v4
ran codemod to remove + update React imports
update eslint to match react w/o import
tsconfig needs to be "react-jsx" instead of "react" now to support jsx transform
existing typescript errors
TS2769: No overload matches this call. Overload 1 of 2, '(props: ReplaceProps<"symbol", BsPrefixProps<"symbol"> & ColProps> | Readonly<ReplaceProps<"symbol", BsPrefixProps<"symbol"> & ColProps>>): Col<...>', gave the following error. Type '"symbol" | "object" | "title" | "cite" | "data" | "form" | "label" | "pattern" | "span" | "summary" | "slot" | "style" | ComponentClass<any, any> | FunctionComponent<any> | ... 163 more ... | undefined' is not assignable to type '"symbol" | undefined'. Type '"object"' is not assignable to type '"symbol" | undefined'. Overload 2 of 2, '(props: ReplaceProps<"symbol", BsPrefixProps<"symbol"> & ColProps>, context: any): Col<"symbol">', gave the following error. Type '"symbol" | "object" | "title" | "cite" | "data" | "form" | "label" | "pattern" | "span" | "summary" | "slot" | "style" | ComponentClass<any, any> | FunctionComponent<any> | ... 163 more ... | undefined' is not assignable to type '"symbol" | undefined'. Type '"object"' is not assignable to type '"symbol" | undefined'.
Error while building the project hospitalrun#363
causes build to fail, so change type to keyof JSX.IntrinsicElements, and typings match appropriately
Newly added dependencies with Bundlephobia links:
Note: pull requests without proper descriptions may simply be closed without further discussion. We appreciate your contributions, but need to know what you are offering in clearly described format. Provide tests for all code that you add/modify. If you add/modify any components update the storybook. Thanks! (you can delete this text)