Remove reference to OS X. #765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OS X is now known as macOS.
carlocab
reviewed
Apr 22, 2023
Comment on lines
533
to
+535
| elif version_lt "${macos_version}" "10.11" | ||
| then | ||
| abort "Your OS X version is too old." | ||
| abort "Your macOS version is too old." |
There was a problem hiding this comment.
OS X was renamed to macOS in version 10.12, but this message shows only if the version is less than 10.11, so "OS X" here is probably correct.
There was a problem hiding this comment.
Yes, note that above it also says Mac OS X for versions below 10.7.
|
The naming is correct for the OS version it is shown on. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OS X is now known as macOS.