cleanup_before: clean /Library/Frameworks directory
#916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These directories contain headers and libraries that we don't want to use, so let's get rid of them when building on a GitHub macOS runner. The Mono framework in particular contains Gettext headers that I've seen mess up CMake builds in the past.
7 tasks
MikeMcQuaid
reviewed
Apr 27, 2023
lib/tests/cleanup_before.rb
Outdated
Comment on lines
26
to
39
| delete_or_move Pathname.glob(HOMEBREW_CELLAR/"*") | ||
|
|
||
| frameworks_dir = Pathname("/Library/Frameworks") | ||
| %w[ | ||
| Mono.framework | ||
| PluginManager.framework | ||
| Python.framework | ||
| R.framework | ||
| Xamarin.Android.framework | ||
| Xamarin.Mac.framework | ||
| Xamarin.iOS.framework | ||
| ].each do |framework| | ||
| path = frameworks_dir/framework | ||
| test "sudo", "mv", path, HOMEBREW_TEMP if path.exist? |
There was a problem hiding this comment.
Can this use delete_or_move instead?
There was a problem hiding this comment.
Needs sudo, unfortunately. Would you rather we refactor delete_or_move to use sudo when requested?
There was a problem hiding this comment.
@carlocab Might make sense but: up to you, no strong feelings other way!
carlocab
force-pushed
the
clean-frameworks
branch
from
cfe64a6
to
3570759
Compare
carlocab
force-pushed
the
clean-frameworks
branch
from
5410898
to
3bb4434
Compare
MikeMcQuaid
approved these changes
Apr 27, 2023
|
Thanks @carlocab! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These directories contain headers and libraries that we don't want to
use, so let's get rid of them when building on a GitHub macOS runner.
The Mono framework in particular contains Gettext headers that I've seen
mess up CMake builds in the past.