-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packer 1.9.4 #198616
packer 1.9.4 #198616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The formula is disabled though and will be dropped on 2025-09-27
🤖 An automated task has requested bottles to be published to this PR. |
|
@iMichka any idea if the bottle push failure is transient, or there's could be something wrong with my changes? 🤔 |
The fact that this formula is disabled means that we don't build it anymore, so we have nothing to publish. It also means that this formula is no longer installable so I'm afraid this change will not affect any end user. |
I don't understand why it needs to be disabled, though. Should we deprecate it instead? 1.9.4 is not affected by the BUSL-1.1 change and is still usable. /cc @iMichka |
Implemented in 8a58e85 (had to rebase into 354d172, though, to pass the commit style test). Here's one more example of a license change that uses homebrew-core/Formula/t/tart.rb Lines 16 to 17 in cb88b10
Looks like a better way to do it. |
8a58e85
to
354d172
Compare
Because it had been deprecated for a year. This follows the standard formula deprecation cycle. And it was deprecated because it was relicensed to a non-free license, as documented in the formula.
I see that your change to this formula is simple enough and only affects the version before the re-licensing happened. However, I don't think this is a strong enough reason to re-enable the formula. I'm asking @Homebrew/core for opinions. |
Can you please quote the relevant paragraph from that document? Because I only see a rule about removing the formulas that have been disabled for over a year, and nothing about disabling a deprecated formula after a year. |
https://docs.brew.sh/Deprecating-Disabling-and-Removing-Formulae#disabling:
|
I see, thanks! I'm going to close this PR then, sorry for the noise. Also just realized that HashiCorp now has their own tap where this change can be introduced instead. |
Yes, you're better off using a third-party tap since we don't accept such a non-free formula here in the official tap. Thanks for being understanding, @edigaryev! |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Similarly to #198462.
Fixes: