Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsign: add build option #198603

Merged
merged 2 commits into from
Nov 23, 2024
Merged

jsign: add build option #198603

merged 2 commits into from
Nov 23, 2024

Conversation

ebourg
Copy link
Contributor

@ebourg ebourg commented Nov 22, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. java Java use is a significant feature of the PR or issue labels Nov 22, 2024
@daeho-ro
Copy link
Member

Can you explain why do we need the build option?

@daeho-ro daeho-ro changed the title Fix jsign.rb for the HEAD versions jsign: fix for the HEAD versions Nov 23, 2024
@ebourg
Copy link
Contributor Author

ebourg commented Nov 23, 2024

@daeho-ro Yes, in the developement version of Jsign the jsign-core module has been split in two parts, jsign-core and jsign-crypto, with jsign-core depending on jsign-crypto. The current formula doesn't build the jsign-crypto module and fails to build with --HEAD. Adding the --also-make option ensures that any module required by the modules listed in the mvn command will also be built, so the formula will work with Jsign 6.0 and later.

@daeho-ro daeho-ro changed the title jsign: fix for the HEAD versions jsign: add build option Nov 23, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 23, 2024
@daeho-ro daeho-ro added the automerge-skip `brew pr-automerge` will skip this pull request label Nov 23, 2024
Copy link
Member

@daeho-ro daeho-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ebourg , it looks fine.

@ebourg
Copy link
Contributor Author

ebourg commented Nov 23, 2024

Thanks!

@daeho-ro daeho-ro removed the automerge-skip `brew pr-automerge` will skip this pull request label Nov 23, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 23, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 23, 2024
Merged via the queue into Homebrew:master with commit 2263373 Nov 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. java Java use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants