Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opencascade 7.8.1 #175902

Merged
merged 6 commits into from
Jun 30, 2024
Merged

opencascade 7.8.1 #175902

merged 6 commits into from
Jun 30, 2024

Conversation

joe-warren
Copy link

Created with brew bump-formula-pr.

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Jun 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@chenrui333

This comment was marked as resolved.

Sign in to view
@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Jun 28, 2024
@joe-warren-permutive
opencascade 7.8.1
f129db3 
Additionally modify the opencascade test to use C++ 11, as this is (or more recent)
is required by recent versions of opencascade
@joe-warren
Copy link
Author

I've also modifed the opencascade test to use C++ 11, as this is (or more recent) is required by recent versions of opencascade.

@joe-warren-permutive
f3d 2.4.0 increment revision
49f9e39 
As I understand it, this forces f3d to be rebuilt in response to an
updated version of the opencascade dependency
@joe-warren
Copy link
Author

I think f3d just needs rebuilding, which I think can be done by bumping the revision?

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core labels Jun 29, 2024
@github-actions github-actions bot removed automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core labels Jun 29, 2024
@joe-warren-permutive
gmsh 4.13.1 increment revision
2192afe 
As I understand it, this forces gmsh to be rebuilt in response to an
updated version of the opencascade dependency
@joe-warren
Copy link
Author

I'm not totally sure what to do about this; I'm 90% sure that gmsh and f3d should work with opencascade 7.8.1, but they need rebuilding
I've incremened the revision of those packages to reflect this (although I'm not sure that this is correct?).
However, it looks like CI is now timing out now it's trying to build 3 packages.

Any help or advice would be appreciated?

@joe-warren
Copy link
Author

Opened a discussion here for visibility

@ZhongRuoyu ZhongRuoyu added long build Set a long timeout for formula testing and removed test failure CI fails while running the test-do block labels Jun 30, 2024
ZhongRuoyu
ZhongRuoyu approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution to Homebrew, @joe-warren!

@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 30, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jun 30, 2024
Merged via the queue into Homebrew:master with commit 566601d Jun 30, 2024
14 checks passed
@joe-warren joe-warren deleted the bump-opencascade-7.8.1 branch June 30, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhongRuoyu ZhongRuoyu ZhongRuoyu approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joe-warren @chenrui333 @ZhongRuoyu @BrewTestBot @joe-warren-permutive