Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rattler-build: build tui features #175877

Merged
merged 2 commits into from
Jun 30, 2024
Merged

rattler-build: build tui features #175877

merged 2 commits into from
Jun 30, 2024

Conversation

pavelzw
Copy link
Contributor

@pavelzw pavelzw commented Jun 28, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. rust Rust use is a significant feature of the PR or issue labels Jun 28, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 28, 2024
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jun 29, 2024
@chenrui333
Copy link
Member

looks like the build was flaky and it is good now.

@pavelzw pavelzw marked this pull request as ready for review June 30, 2024 05:42
@pavelzw @chenrui333
rattler-build: build tui features
752fd0a 
rattler-build: revision bump

Signed-off-by: Rui Chen <[email protected]>
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@Homebrew Homebrew deleted a comment from github-actions bot Jun 30, 2024
@chenrui333
Copy link
Member

since this has feature change, let's also revision bump the formula.

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jun 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

:shipit: @chenrui333 has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 30, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jun 30, 2024
Merged via the queue into Homebrew:master with commit 221d866 Jun 30, 2024
14 checks passed
@pavelzw pavelzw deleted the patch-1 branch June 30, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pavelzw @chenrui333 @BrewTestBot