Add Sound Blaster Control App

[iMonZ]

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

• brew cask audit --download {{cask_file}} is error-free.
• brew cask style --fix {{cask_file}} reports no offenses.
• There are no open pull requests for the same update.
• The submission is for a stable version or documented exception.

Additionally, if adding a new cask:

• Named the cask according to the token reference.
• brew cask install {{cask_file}} worked successfully.
• brew cask uninstall {{cask_file}} worked successfully.
• Checked the cask was not already refused.
• Checked the cask is submitted to the correct repo.

[vitorgalvao]

Failing with

uninstall script /Applications/Creative/Uninstaller.app/Contents/MacOS/Uninstaller does not exist.

[ran-dall]

@iMonZ Where you going to take a look at this, or should we proceed with closing this out?

[iMonZ]

Oh I’m sorry I thought this was closed! Im fixing this today

…

Am 12.07.2020 um 01:08 schrieb Randall ***@***.***>:  @iMonZ Where you going to take a look at this, or should we proceed with closing this out? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[vitorgalvao]

Needs to be submitted to homebrew/cask-drivers, it seems. We define drivers as:

Software to make a hardware peripheral recognisable and usable by the system. If the software is useless without the peripheral, it’s considered a driver.

Note that repo has special naming rules.

What are the names of the apps this installs under /Applications/Creative?

[iMonZ]

Needs to be submitted to homebrew/cask-drivers, it seems. We define drivers as:

Software to make a hardware peripheral recognisable and usable by the system. If the software is useless without the peripheral, it’s considered a driver.

It‘s the same kind as #83746 and this is also an Cask (because this is an control App for this device)

• [ ]

What are the names of the apps this installs under /Applications/Creative?

This will be automatically uninstalled with the installer script!

[iMonZ]

/Applications/Creative
Creative Uninstaller.app
Product Registration.app
Sound Blaster Control Panel.app

[vitorgalvao]

It‘s the same kind as #83746

Which looks like it too should be in the drivers repo.

because this is an control App for this device

If it controls a device, it definitely belongs in the other repo.

This will be automatically uninstalled with the installer script!

Not why I’m asking. I really do want the names of the apps.

[vitorgalvao]

Would be more compliant with the rules to be sound-blaster-control-panel.

[reitermarkus]

@iMonZ, please rebase this and adjust the style to the new rules.

[vitorgalvao]

Definitely looks like it belongs in homebrew/cask-drivers. I’ll move the other cask.

There’s been no reply on this for over a month, so I’ll close it. It can be resubmitted to the correct repo with the requested fixes.

please rebase this and adjust the style to the new rules.

User rebases remove the ability to see what changed between commits, which means we have to reevaluate the whole cask every time. Since cask submissions should always be a single commit, it’s better if we do it ourselves through the Github interface or a script (that’s an example).