Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete google-cloud-sdk.rb #29806

Merged
merged 1 commit into from
Feb 4, 2017
Merged

Delete google-cloud-sdk.rb #29806

merged 1 commit into from
Feb 4, 2017

Conversation

vitorgalvao
Copy link
Member

Same logic as #29747, #29748, #29749.

@vitorgalvao vitorgalvao merged commit 237ff67 into master Feb 4, 2017
@vitorgalvao vitorgalvao deleted the del-google-cloud-sdk branch February 4, 2017 19:11
@miccal miccal removed the discussion label Feb 4, 2017
@toonetown
Copy link
Contributor

I actually was using it...but I'm fine with its removal if it doesn't match policy.

The application, however, is run and installed ONLY into the actual caskroom directory...so just fully removing /usr/local/Caskroom/google-cloud-sdk will delete everything (I think that's what the "default" uninstall does - according to #6872 ) So I'm not clear on what actually needs to be added as an uninstall stanza.

The discussion at https://groups.google.com/forum/#!topic/google-cloud-sdk/ppP3vTW4aIo explains this - and the modifications to rc files described at that link are not done in the cask (the cask installs with --bash-completion false, --path-update false and --rc-path false.

Also - reading through the source of the install.sh script that gets run, it actually does just install everything into the caskroom staged directory.

However, as I said at the beginning, I'm fine with this cask being removed. I just thought I'd add a bit more information around the uninstallation.

@vitorgalvao
Copy link
Member Author

vitorgalvao commented Feb 4, 2017

@toonetown Actually, that means the cask was already fine. Thank you for the information and the research.

Readding in #29832 with a new note.

@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants