Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cocktail 17.3.1 #178165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cocktail 17.3.1 #178165

wants to merge 1 commit into from

Conversation

khipp
Copy link
Contributor

@khipp khipp commented Jun 30, 2024

Created by brew bump


Created with brew bump-cask-pr.

@BrewTestBot BrewTestBot added the bump-cask-pr PR was created using `brew bump-cask-pr` label Jun 30, 2024
@bevanjkay
Copy link
Member

@SMillerDev I'm not sure why the rosetta audit is failing here, the caveats aren't being read correctly on older versions, or perhaps it is to do with simulating the architecture with brew audit?

@khipp
Copy link
Contributor Author

khipp commented Jul 2, 2024

The caveat requires_rosetta has a guard clause that checks the contents of the RUBY_PLATFORM environment variable:

caveat :requires_rosetta do
  next unless Hardware::CPU.arm?

  <<~EOS
    #{@cask} is built for Intel macOS and so requires Rosetta 2 to be installed.
    You can install Rosetta 2 with:
      softwareupdate --install-rosetta --agree-to-license
    Note that it is very difficult to remove Rosetta 2 once it is installed.
  EOS
end

I'm not familiar with the CI but noticed that the runner-images for macos-14 are both based on macos-14-arm64 and the ones for macos-13 and macos-12 seem to be based in intel (macos-13 and macos-12 respectively).
Depending on how RUBY_PLATFORM is set here,

mentions_rosetta = cask.caveats.include?("requires Rosetta 2")

would evaluate to false and fail the audit.

@p-linnane p-linnane requested a review from a team July 3, 2024 16:00
@p-linnane p-linnane added the awaiting maintainer feedback Issue needs response from a maintainer. label Jul 3, 2024
Copy link

github-actions bot commented Jul 6, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale Issue which has not received any feedback for some time. label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting maintainer feedback Issue needs response from a maintainer. bump-cask-pr PR was created using `brew bump-cask-pr` stale Issue which has not received any feedback for some time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants