talkdesk 2.0.1 (new cask) #178047
Open
talkdesk 2.0.1 (new cask) #178047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanzigerGeist
changed the title
It should be |
DanzigerGeist
changed the title
|
@krehel thank you for taking a look on this one! I referred to the vendor's documentation for the name, but having it just as "Talkdesk" should not cause any confusion - so I renamed it as per yours request. |
bevanjkay
reviewed
Jun 30, 2024
| @@ -0,0 +1,29 @@ | |||
| # https://support.talkdesk.com/hc/en-us/articles/13920616167963-Workspace-Desktop-App-for-Talkdesk-CX-Cloud | |||
There was a problem hiding this comment.
Suggested change
| # https://support.talkdesk.com/hc/en-us/articles/13920616167963-Workspace-Desktop-App-for-Talkdesk-CX-Cloud |
bevanjkay
reviewed
Jun 30, 2024
| verified: "td-infra-prd-us-east-1-s3-atlaselectron.s3.amazonaws.com/" | ||
| name "Talkdesk Workspace Desktop for MacOS" | ||
| desc "Desktop app that allows you to use Talkdesk as stand-alone software" | ||
| homepage "https://www.mytalkdesk.com/atlas/download" |
There was a problem hiding this comment.
Is there a better url that can be used for the Homepage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.NOTE: Running
brew audit --cask --new <cask>throws a warning: "cask token mentions desktop". I would like to request an exception since the official application name is Talkdesk Desktop.