New exception if uninstall fails but cask is installed #12076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alebcay
added
core
|
Pinging @ndr-qef @phinze. |
|
We’ll be having some changes in the future that should render this unecessary, but I’ll keep it open for now. |
|
Here are the news: #13201. Thank you for working on this, but it will no longer be needed. |
miccal
removed
core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the well-known problem with uninstalling casks when the version has been incremented a bit ago (see for example #2988); my understanding is that this error would be simple to fix but right now it exists due to the project looking forward to
brew cask upgrade. I think an exception like this is helpful: it informs the users that the problem is known and tells them how to proceed. All that's needed is to check/opt/homebrew-cask/Caskroom/[cask]rather than checking for a specific version. I'm really not very familiar with Ruby. If there's interest in merging this in I can try to look at tests as necessary but I'd appreciate help.