Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brew bundle dump selections #1217

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

tony-sol
Copy link
Contributor

@tony-sol tony-sol commented Jun 12, 2023

Add brew bundle dump selections #1212

Flags of brew bundle list like --all, --casks now available for brew bundle dump.
Without flag, brew bundle dump writes all dependencies, as like with --all flag.
Adding any other selection, like --brews, disables implicit --all.

Review and merge after #1216

@MikeMcQuaid
Copy link
Member

Review and merge after #1216

If it's rebased: I think this is likely to be mergeable faster?

@tony-sol tony-sol marked this pull request as ready for review June 12, 2023 18:38
@tony-sol
Copy link
Contributor Author

@MikeMcQuaid done, completely separated from previous PR

Copy link
Member

@colindean colindean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These arg lists are too long but let's go with it for now and refactor later.

@tony-sol
Copy link
Contributor Author

@colindean agreed, but don't get yet how to make is more smooth

Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MikeMcQuaid MikeMcQuaid merged commit 9db2ccc into Homebrew:master Jun 13, 2023
4 checks passed
@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @tony-sol!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2023
@tony-sol tony-sol deleted the dump-groups-selection branch June 13, 2024 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants