Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/install: infer --overwrite when in GitHub Actions #18612

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

cmd/install: infer --overwrite when in GitHub Actions #18612

wants to merge 3 commits into from

Commits on Oct 23, 2024

  1. cmd/install: infer --overwrite when in GitHub Actions 

    Based on discussion at Homebrew/homebrew-core#195288.

I was initially inclined to scope this only to Python, but I think it
makes sense to apply more generally. The issue is that users often have
no control over what's already inside `HOMEBREW_PREFIX` when they run
`brew install`. Given that, I think it makes sense to assume users want
`--overwrite` unless configured otherwise with
`HOMEBREW_GITHUB_ACTIONS_NO_INSTALL_OVERWRITE`.
    @carlocab
    carlocab committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    4c6cadd View commit details
    Browse the repository at this point in the history

  2. formula_installer: propagate --overwrite flag to dependencies

    @carlocab
    carlocab committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    79959ca View commit details
    Browse the repository at this point in the history

  3. Also set --overwrite for pre-install checks 

    And skip displaying the message if `--overwrite` was already requested.
    @carlocab
    carlocab committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    04d7c40 View commit details
    Browse the repository at this point in the history