Load tap migration renames from api #17599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These would not get loaded from the API at all meaning these were not loadable by the old names when the core formula or cask tap was not installed. We assume that most users don't have those core taps tapped which means this is broken for most everyone.
Check for the following: - Tap migration rename to core tap can be loaded by short name - Tap migration rename to core tap can be loaded by long name - Tap migration renam that clashes with existing core tap short name is ignored in favor of loading the cask/formula from the core tap
apainintheneck
force-pushed
the
load-tap-migration-renames-from-api
branch
from
668ac93
to
fb3b13e
Compare
9 tasks
apainintheneck
commented
Jun 30, 2024
MikeMcQuaid
approved these changes
Jul 1, 2024
|
Thanks for helping fix this issue. I've tried the change myself, but it seems the brew/Library/Homebrew/cask/cask_loader.rb Line 468 in fb3b13e brew/Library/Homebrew/formulary.rb Line 835 in fb3b13e |
7 tasks
|
@Logicer16 Thanks for catching that! I opened a PR that should address the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Alternative approach to #17555 that is simpler and exactly matches the current behavior. The only downside is that the type system wasn't happy and I had to use an escape hatch.
Fixes #17234