cask/audit: filter bad artifacts in rosetta audit

[krehel]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

Follow up to #17573 to address the following -

1. Remove binary artifacts if they are part of an app bundle. This was the same change I made in signing detection to avoid checking shell scripts or other plain files. Visual Studio Code, for example, fails without this change as a shell script artifact is picked up for assessment.

2. Filter out files like .dylib and folders that shouldn't be in the <app>/Contents/MacOS/folder, but are there anyway. (See wondershare-uniconverter 15.5.13 homebrew-cask#177949 for a failure scenario)

[MikeMcQuaid]

Thanks @krehel!

1. This was the same change I made in signing detection to avoid checking shell scripts or other plain files

This makes me wonder if there's the potential for this to be extracted into a helper method. Are we using it anywhere else beyond those 2 places?

[krehel]

@MikeMcQuaid just those two places, but there is some refinement here I would like to dig into after this is merged like your mention of extraction to iterate an improved solution.

This is meant to prevent PRs from stacking up on spurious failures.

[SMillerDev]

Yeah, I was also considering splitting into a generic artifact audit but I didn't quite come up with a format yet.

[MikeMcQuaid]

Thanks again @krehel!