Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tap migration renames with API #17555

Closed
wants to merge 3 commits into from

Commits on Jun 28, 2024

  1. fix tap migration renames with API

    We don't load casks and formulae that used to exist in an external
    tap but have been moved and renamed to an API tap when using the
    API. Loading works correctly when the core formula or cask tap
    is tapped locally though.
    
    This PR adds some logic to map tap migration renames to the API
    and check that when loading formulae and casks.
    apainintheneck committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    e16bde1 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. Add tests

    Check for the following:
    - Tap migration rename to core tap can be loaded by short name
    - Tap migration rename to core tap can be loaded by long name
    - Tap migration renam that clashes with existing core tap short name
      is ignored in favor of loading the cask/formula from the core tap
    apainintheneck committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    18d2373 View commit details
    Browse the repository at this point in the history
  2. show migrated from when loading packages from API

    This changes slightly how we load packaged migrated to core taps
    when they are loaded using the API. Now it should show the warning
    that the package has been migrated and renamed.
    apainintheneck committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    0c81a31 View commit details
    Browse the repository at this point in the history