Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore runner labels in actionlint #17506

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

shivammathur
Copy link
Contributor

@shivammathur shivammathur commented Jun 14, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR adds an ignore flag to actionlint to ignore GitHub Actions runner labels.

@Bo98
Copy link
Member

Bo98 commented Jun 14, 2024

This is very Homebrew-specific naming and I don't think it makes sense for third-party taps to be mandated to match one of these.

homebrew-large-bottle-build is already deprecated and linux-self-hosted-1 will be soon be replaced with a new name.

I'd probably be OK disabling the check entirely tbh, or certainly at least for third-party taps. Should be possible to dynamically pass -ignore values in style.rb.

@MikeMcQuaid
Copy link
Member

I'd probably be OK disabling the check entirely tbh

Me too, let's not bother being different for third-party taps here, it's not a useful check for the Homebrew ecosystem. @shivammathur you should be able to pass another -ignore, shout if you need help here!

@shivammathur shivammathur changed the title Add self-hosted runner labels for actionlint Ignore runner labels in actionlint Jun 14, 2024
@shivammathur
Copy link
Contributor Author

@Bo98 @MikeMcQuaid I have updated the PR.

@MikeMcQuaid
Copy link
Member

Thanks again @shivammathur, great work!

@MikeMcQuaid MikeMcQuaid merged commit 2143593 into Homebrew:master Jun 14, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants