API: Load casks/formula from JSON with missing keys #16420
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Related to the discussion in #16410 and the first bullet point in #16410 (comment).
We'd like to reduce the size of the API JSON and to do that we are going to remove unused and/or blank elements from the cask/formula definition. This will reduce the amount of data that has to go over the wire and make it easier to load this data into memory.
Beyond the code I've changed here, there are a few other spots that I've decided not to update to handle null values because they should always be present anyway and if they're missing, we'll have bigger problems to deal with.
brew/Library/Homebrew/formulary.rb
Line 288 in 080e61f
brew/Library/Homebrew/cask/cask_loader.rb
Line 338 in 080e61f