-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump-cask-pr
: add arch-specific version support
#15725
bump-cask-pr
: add arch-specific version support
#15725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looking good so far, much easier to review!
# Class handling architecture-specific version information. | ||
# | ||
# @api private | ||
class VersionParser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class VersionParser | |
class Homebrew::BumpVersionParser |
or similar. Feels like it should be:
- in Homebrew module
- reference
Bump
in the name
Also, don't put it in extend
as it's not extending an existing class
|
||
describe "brew bump-cask-pr" do | ||
it_behaves_like "parseable arguments" | ||
|
||
describe Homebrew::VersionParser do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to its own test file
8307890
to
33375ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks again @razvanazamfirei!
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?I am splitting #15611 into separate PRs. The current PR should be mergeable by itself. Once done, I will open a PR for the
bump
command.This pull request introduces significant updates to
bump-cask-pr.rb
as well as new classVersionParser
.Changes:
bump-cask-pr
has been refactored.bump-cask-pr
should now accept--version-intel
and--version-arm
.cask/cask.rbi
has been sorted andon_system_blocks_exist?
was added.bump-cask-pr
.