Merge pull request #17589 from Homebrew/autoremove-skip-nil

Homebrew · Jun 29, 2024 · fda555d · fda555d
2 parents a40f327 + e28d455
commit fda555d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/Library/Homebrew/test/utils/autoremove_spec.rb b/Library/Homebrew/test/utils/autoremove_spec.rb
@@ -107,6 +107,13 @@
       expect(described_class.send(:unused_formulae_with_no_formula_dependents, formulae))
         .to match_array(formulae)
     end
+
+    specify "installed on request is null" do
+      allow(tab_from_keg).to receive(:installed_on_request).and_return(nil)
+
+      expect(described_class.send(:unused_formulae_with_no_formula_dependents, formulae))
+        .to eq([])
+    end
   end
 
   shared_context "with formulae and casks for dependency testing" do

diff --git a/Library/Homebrew/utils/autoremove.rb b/Library/Homebrew/utils/autoremove.rb
@@ -61,8 +61,8 @@ def bottled_formulae_with_no_formula_dependents(formulae)
       # @private
       sig { params(formulae: T::Array[Formula]).returns(T::Array[Formula]) }
       def unused_formulae_with_no_formula_dependents(formulae)
-        unused_formulae = bottled_formulae_with_no_formula_dependents(formulae).reject do |f|
-          f.any_installed_keg&.tab&.installed_on_request
+        unused_formulae = bottled_formulae_with_no_formula_dependents(formulae).select do |f|
+          f.any_installed_keg&.tab&.installed_on_request == false
         end
 
         unless unused_formulae.empty?