Merge pull request #3401 from DomT4/vendor_or_na

go: various tweaks to recommendations
Homebrew · Dec 16, 2017 · b4d43e9 · b4d43e9
2 parents deb3749 + bff4762
commit b4d43e9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/Library/Homebrew/rubocops/text_cop.rb b/Library/Homebrew/rubocops/text_cop.rb
@@ -46,7 +46,16 @@ def audit_formula(_node, _class_node, _parent_class_node, body_node)
           end
 
           find_method_with_args(body_node, :system, "go", "get") do
-            problem "Formulae should not use `go get`. If non-vendored resources are required use `go_resource`s."
+            problem "Do not use `go get`. Please ask upstream to implement Go vendoring"
+          end
+        end
+      end
+    end
+    module FormulaAuditStrict
+      class Text < FormulaCop
+        def audit_formula(_node, _class_node, _parent_class_node, body_node)
+          find_method_with_args(body_node, :go_resource) do
+            problem "`go_resource`s are deprecated. Please ask upstream to implement Go vendoring"
           end
         end
       end

diff --git a/Library/Homebrew/test/rubocops/text_cop_spec.rb b/Library/Homebrew/test/rubocops/text_cop_spec.rb
@@ -66,7 +66,7 @@ class Foo < Formula
 
           def install
             system "go", "get", "bar"
-            ^^^^^^^^^^^^^^^^^^^^^^^^^ Formulae should not use `go get`. If non-vendored resources are required use `go_resource`s.
+            ^^^^^^^^^^^^^^^^^^^^^^^^^ Do not use `go get`. Please ask upstream to implement Go vendoring
           end
         end
       RUBY
@@ -139,7 +139,7 @@ class Foo < Formula
 
           def install
             system "go", "get", "bar"
-            ^^^^^^^^^^^^^^^^^^^^^^^^^ Formulae should not use `go get`. If non-vendored resources are required use `go_resource`s.
+            ^^^^^^^^^^^^^^^^^^^^^^^^^ Do not use `go get`. Please ask upstream to implement Go vendoring
           end
         end
       RUBY