Skip to content

Commit

Permalink
dev-cmd/contributions: Tighten up type sigs
Browse files Browse the repository at this point in the history
  • Loading branch information
issyl0 committed Jul 1, 2024
1 parent 3b695c6 commit 9130dd1
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions Library/Homebrew/dev-cmd/contributions.rb
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def time_period(from:, to:)
end
end

sig { params(totals: T::Hash[T.untyped, T.untyped]).returns(String) }
sig { params(totals: T::Hash[String, T::Hash[Symbol, Integer]]).returns(String) }
def generate_csv(totals)
CSV.generate do |csv|
csv << %w[user repo author committer coauthor review total]
Expand All @@ -127,7 +127,14 @@ def generate_csv(totals)
end
end

sig { params(user: String, grand_total: T::Hash[Symbol, T.untyped]).returns(T::Array[T.any(String, Integer)]) }
sig {
params(
user: String,
grand_total: T::Hash[Symbol, Integer],
).returns(
[String, String, T.nilable(Integer), T.nilable(Integer), T.nilable(Integer), T.nilable(Integer), Integer],
)
}
def grand_total_row(user, grand_total)
[
user,
Expand Down

0 comments on commit 9130dd1

Please sign in to comment.