This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Fix pickle error with HPOneViewException #321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamonnotoole
force-pushed
the
fix-pickle
branch
4 times, most recently
from
3216792 to
5e5c071
Compare
This commit fixes HewlettPackard#320. The problem seems to be that when oneview_response is not None the Exception base class is called with two arguments whereas HPOneViewException is defined to have one argument. This fix overrides the __reduce__ method so that pickle will recognise the situation where two arguments are used.
eamonnotoole
force-pushed
the
fix-pickle
branch
from
5e5c071 to
86ecea2
Compare
AnushaY1916
pushed a commit
that referenced
this pull request
Mar 2, 2018
FC network tested and changed for 600
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #320.
The problem seems to be that when oneview_response is not None the
Exception base class is called with two arguments whereas
HPOneViewException is defined to have one argument. A simple fix is to
append self.oneview_response to self.msg and pass call Exception with
just self.msg
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve. e.g., Fixes #1]
Check List
$ tox).