Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Wait until winetricks lists before allowing the user to search #4226

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Dec 31, 2024

When opening the Winetricks dialog, if a user starts typing too fast in the input field before we get the list of valid components/fonts then it will look like nothing is found. Many users reported that in discord.

This PR changes the dialog to show a message while we are loading the list of things available so users can't type while it's loading, and then we allow searching only once it's ready.

This should make it less confusing for users.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 31, 2024
@arielj arielj requested review from Etaash-mathamsetty, a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team December 31, 2024 02:11
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (and it works when I tested it)

@CommandMC CommandMC merged commit 20768ea into main Jan 2, 2025
9 checks passed
@CommandMC CommandMC deleted the winetricks-dialog-wait-for-list branch January 2, 2025 18:37
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants