Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Show Crossover bottle in installed info details #4194

Merged
merged 1 commit into from
Jan 2, 2025
Merged

[Fix] Show Crossover bottle in installed info details #4194

merged 1 commit into from
Jan 2, 2025

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Dec 21, 2024 •
edited
Loading

We have a bug on Mac, when using Crossover, the game details page shows the wineprefix instead of the bottle name in the Installed Info area, when wine prefix makes no sense in that case.

There was code already for that but it was bugged.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 21, 2024
@arielj arielj requested review from Etaash-mathamsetty, a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team December 21, 2024 17:27
CommandMC
CommandMC approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test this, but sounds & looks fine to me

src/frontend/screens/Game/GamePage/components/InstalledInfo.tsx Show resolved Hide resolved
@arielj arielj merged commit 85b8954 into main Jan 2, 2025
9 checks passed
@arielj arielj deleted the show-bottle-if-crossover branch January 2, 2025 23:12
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CommandMC CommandMC CommandMC approved these changes

@Etaash-mathamsetty Etaash-mathamsetty Awaiting requested review from Etaash-mathamsetty

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielj @CommandMC