[UX/Fix] Respect experimental UMU support disabled #4191
+21
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few days ago I made this PR #4175 making UMU the default when running games with Proton.
There's a problem with that PR: if a game was running with Proton and UMU disabled, updating heroic will make the game run with UMU incorrectly (affecting its prefix irreversibly, maybe breaking it if the game is incompatible with UMU).
To avoid that, we have to also check if UMU was not used before for games that are already installed.
So: for new games, the
disableUMU
setting will befalse
by default ortrue
if changed by the user, so it will ignore the old experimental feature value. For games installed before this change, thedisableUMU
setting will beundefined
so we check the experimental feature value.How to test:
revert some commit to have the experimental UMU and disable it
install a game and run it once using proton without the experimental feature
update to this commit
run the game again
it should NOT use UMU (even though the
Disable UMU
check is disabled in the advanced tab)revert some commit to have the experimental UMU and enable it
install a game and run it once using proton with the experimental feature
update to this commit
run the game again
it should use UMU
Use the following Checklist if you have changed something on the Backend or Frontend: