Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue on Galapagos logo click. #317

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

Hussam-hg
Copy link
Collaborator

No description provided.

@@ -110,5 +110,7 @@ export class HeaderComponent implements OnInit {
}
}


navigateToDashboard() {
void this.router.navigate(['/dashboard']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "void"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With out void there was a warning (Promise returned from navigate is ignored )

Copy link
Member

@albrechtflo-hg albrechtflo-hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check why you have "void" in the handler method - aside from that, fine for me.

@Hussam-hg Hussam-hg merged commit 770d4bf into HermesGermany:main Jun 21, 2024
3 checks passed
@Hussam-hg Hussam-hg deleted the bug_4242 branch September 11, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants