add schedule entrance and job name para #107
Open
+445
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli/schedule.py
Outdated
|
|
||
| @click.command(context_settings=dict(help_option_names=["-h", "--help"])) | ||
| @click.option( | ||
| "-cn", |
There was a problem hiding this comment.
why do you need chain name?
There was a problem hiding this comment.
Because some configurations depend on the chain, just like the selection of protocol ID in Uniswap v3.
And some table fields have chain names.
But it is true that this will be removed due to the configuration change of the address
cli/schedule.py
Outdated
| envvar="DBLINK_URL", | ||
| help="dblink to take token price, maybe moved to other replace later", | ||
| ) | ||
| @click.option( |
There was a problem hiding this comment.
You can only run one job at a time?
There was a problem hiding this comment.
Yes, but it has changed now.
| envvar="POSTGRES_URL", | ||
| help="The required postgres connection url." "e.g. postgresql+psycopg2://postgres:[email protected]:5432/ethereum", | ||
| ) | ||
| @click.option( |
There was a problem hiding this comment.
I suggest not to add this. You can assume you have token price table in postgres-url
# Conflicts: # indexer/aggr_jobs/ordered_tasks/models/period_feature_holding_balance_merchantmoe.py # indexer/aggr_jobs/ordered_tasks/models/period_feature_holding_balance_uniswap_v3.py # indexer/aggr_jobs/ordered_tasks/models/period_feature_merchant_moe_token_bin.py # indexer/aggr_jobs/ordered_tasks/models/period_feature_uniswap_v3_pool_prices.py # indexer/aggr_jobs/ordered_tasks/models/period_feature_uniswap_v3_token_details.py # indexer/aggr_jobs/ordered_tasks/period_feature_holding_balance_merchantmoe.sql # indexer/aggr_jobs/ordered_tasks/period_feature_holding_balance_uniswap_v3.sql # indexer/aggr_jobs/regular_tasks/daily_feature_holding_balance_uniswap_v3.sql # indexer/aggr_jobs/regular_tasks/models/daily_feature_uniswap_v3_pool_prices.py # indexer/aggr_jobs/regular_tasks/models/daily_feature_uniswap_v3_token_details.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore lendle jobs...