-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new spiral part where length can be set #14
base: master
Are you sure you want to change the base?
Conversation
Nice Spiral!
About backward compatibility: I'd guess it would be good to first deprecate the old spiral and have both for one version. Afterwards, we remove the old one and then also replace the name? |
Yeah, about backwards compatibility I'm also not sure. One could try to make it backwards compatible to the old spiral, but I think that would be a rather ugly hack, so maybe it's better to go with two spirals for now and replace the old one later on... |
No, I think finally the spiral should just be replaced, so please no ugly hacks ;) |
Could you add squared spiral with euler bend? |
@HelgeGehring Can you add the changelog entry as you see fit? Other than that I think it's ready for review |
- Fix spiral direction
This replaces the old spiral with a new version of an archimedean spiral which allows to set the length. The number of turns required to achieve the length is determined numerically (afaik an analytical solution doesn't exist).
Different types are supported. Especially for use inside an MZI the
inline
andinline_rel
types are of interest.ToDo's before merge: