Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:#170 error handling message #171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix:#170 error handling message #171

wants to merge 1 commit into from

Conversation

Dibyanshuaman
Copy link

No description provided.

@shahharsh176
Copy link
Contributor

Hi @Dibyanshuaman

In the issue #170, the app_name referred to is the Zelthy App, not the Django app. Zelthy operates on a multi-tenant architecture, where each tenant is a Zelthy app with a unique app_name.

Both ws_makemigration and ws_migrate commands have a positional argument called workspace (which represents the Zelthy app_name). We query the TenantModel to retrieve the corresponding tenant object using TenantModel.objects.get(name=options["workspace"]). Therefore, we need to add validation for invalid app_name and raise an error if it doesn't exist in the TenantModel.

Can you please make the necessary changes accordingly?
Let me know if you have any questions.

@shahharsh176
Copy link
Contributor

Hi @Dibyanshuaman , got a chance to check the above comment and work on the changes?

ChrisMcLernon added a commit to ChrisMcLernon/Zango that referenced this pull request Jun 21, 2024
@ChrisMcLernon
fix:Healthlane-Technologies#170 error handling message Healthlane-Tec…
5acb82c 
…hnologies#171
kc-diabeat pushed a commit that referenced this pull request Jun 24, 2024
@ChrisMcLernon
#252, #173, #170: Few Minor Issues Fixed (#258)
f1abdaf 
* modified:   backend/src/zango/apps/appauth/models.py

* modified:   backend/src/zango/cli/start_project.py

* modified:   backend/src/zango/cli/start_project.py

* modified:   backend/src/zango/cli/start_project.py

* Made corrections

* Fixes

* fixed user credential clears

* fix:#170 error handling message #171

* small adjustment to tenantobj to keep consistent

* Fixes: 6-21-2024

* fixed requested issues

* Update ws_makemigration.py

---------

Co-authored-by: Chris McLernon <[email protected]>
Co-authored-by: chris-mclernon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dibyanshuaman @shahharsh176