Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keoni edits to resource md changes 10 25 24 #123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Keyology
Copy link
Contributor

@kriszyp Please review my changes and let me know your thoughts

@Keyology Keyology requested a review from kriszyp October 30, 2024 15:49
Copy link
Member

@kriszyp kriszyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resources.md updates look to good to me, this seems like some helpful reorganization.
The debugging-harperdb.md simply does not belong in this repository, the document is for entirely different audience with an entirely different set of assumptions than HarperDB users.
If you want to add more information about debugging, I would add some information to the existing debugging.md documentation (is there an intuitive reason why users would expect to have look in two different debugging docs?), and describe when and how they should configure HarperDB to use port ranges (when you need to connect to different threads in devtools), and how debugging differs across different IDEs.
We can provide a link to Node.js's documentation for SSH tunneling which is much better for general purpose usage. The tips and performance profiling info could go in that document as well. This all should be in a separate PR.


## Port Configuration for Debugging

Since DevTools can only connect to one thread per port, we assign specific ports for debugging:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is delivery specific, this is not the default config for HarperDB.

When debugging a specific HarperDB instance, you’ll need to SSH into the instance using port tunneling. Here's how to connect to worker threads 1 and 2 (typically, debugging the main thread isn't needed since it doesn’t handle traffic):

```bash
ssh -L 9230:localhost:9230 -L 9231:localhost:9231 [email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Customer of who?

@kriszyp
Copy link
Member

kriszyp commented Nov 6, 2024

Also, for the resource.md documentation, a great follow-up would be to see if we could break it up into two documents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants