Implement image heap suballocation #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hans-Kristian Arntzen <[email protected]>
Signed-off-by: Hans-Kristian Arntzen <[email protected]>
HansKristian-Work
force-pushed
the
image-heap-suballocate
branch
from
261af6e to
1689d35
Compare
Signed-off-by: Hans-Kristian Arntzen <[email protected]>
Until now, we would never attempt to suballocate small image heaps. Some games, at least Nixxes ports, tend to create lots of smaller heaps. The intent seems to be that the game can use fine-grained residency priority. On implementations without EXT_pageable (e.g. RADV currently), we assume a naive allocation model that cannot take advantage of priorities, so there is no need to consider priority set by applications. In future, should RADV get support for this EXT, we may want to revisit these assumptions. To make image suballocation work better, normalize heap type in allocations. Fixes a potential problem where two different CUSTOM heaps can end up allocating from each other. Normalize the CUSTOM heap type to a standard type and compare those. Ensure that all suballocated heaps have a GLOBAL buffer, but just change the explicit usage. This way we don't have to check the heap flags and RTV heaps and resource heaps can share chunks as long as their memory types match. Signed-off-by: Hans-Kristian Arntzen <[email protected]>
These are typically used for resource heaps and don't need to be cleared in most cases. For RTV cases, they have to be initialized with a clear or discard, and usually that will clear the memory anyway, so this flag is a softer and safer variant of the full "skip clear" flag. Signed-off-by: Hans-Kristian Arntzen <[email protected]>
HansKristian-Work
force-pushed
the
image-heap-suballocate
branch
from
1689d35 to
6130821
Compare
doitsujin
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, we would never attempt to suballocate small image heaps.
Some games, at least Nixxes ports, tend to create lots of smaller heaps.
The intent seems to be that the game can use fine-grained residency
priority. On implementations without EXT_pageable (e.g. RADV currently),
we assume a naive allocation model that cannot take advantage of
priorities, so there is no need to consider priority set by
applications. In future, should RADV get support for this EXT,
we may want to revisit these assumptions.
To make image suballocation work better, normalize heap type in allocations.
Fixes a potential problem where two different CUSTOM heaps
can end up allocating from each other. Normalize the CUSTOM heap type
to a standard type and compare those.
Ensure that all suballocated heaps have a GLOBAL buffer, but just
change the explicit usage. This way we don't have to check the heap
flags and RTV heaps and resource heaps can share chunks as long as
their memory types match.