Skip to content

Commit

Permalink
halium_device: Unify tree for ARM64 and ARM variants
Browse files Browse the repository at this point in the history
  • Loading branch information
muhammad23012009 authored and fredldotme committed Jun 11, 2024
1 parent 8bd53a5 commit cc07c1e
Show file tree
Hide file tree
Showing 8 changed files with 60 additions and 16 deletions.
3 changes: 1 addition & 2 deletions Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

LOCAL_PATH := $(call my-dir)

ifneq ($(filter halium_arm64,$(TARGET_DEVICE)),)
ifneq ($(filter halium_arm64 halium_arm,$(TARGET_DEVICE)),)
include $(call all-makefiles-under,$(LOCAL_PATH))

endif
6 changes: 5 additions & 1 deletion AndroidProducts.mk
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
PRODUCT_MAKEFILES := \
$(LOCAL_DIR)/lineage_halium_arm64.mk
$(LOCAL_DIR)/halium_arm/lineage_halium_arm.mk \
$(LOCAL_DIR)/halium_arm64/lineage_halium_arm64.mk

COMMON_LUNCH_CHOICES := \
lineage_halium_arm-user \
lineage_halium_arm-userdebug \
lineage_halium_arm-eng \
lineage_halium_arm64-user \
lineage_halium_arm64-userdebug \
lineage_halium_arm64-eng
5 changes: 2 additions & 3 deletions BoardConfig.mk
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@

BOARD_VENDOR := halium

DEVICE_PATH := device/halium/halium_arm64

include build/make/target/board/generic_arm64/BoardConfig.mk
DEVICE_PATH := device/halium/halium

TARGET_USES_64_BIT_BINDER := true

Expand All @@ -42,6 +40,7 @@ TARGET_USES_HWC2 := true

# Filesystem
TARGET_USERIMAGES_USE_EXT4 := true
TARGET_USERIMAGES_USE_F2FS := true

# HIDL
DEVICE_FRAMEWORK_MANIFEST_FILE := $(DEVICE_PATH)/framework_manifest.xml
Expand Down
14 changes: 14 additions & 0 deletions halium_arm/BoardConfig.mk
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
-include device/halium/halium/BoardConfig.mk

# Include Legacy GSI patches
include build/make/target/board/generic_arm_ab/BoardConfig.mk

# Architecture
TARGET_ARCH := arm
TARGET_ARCH_VARIANT := armv7-a-neon
TARGET_CPU_ABI := armeabi-v7a
TARGET_CPU_ABI2 := armeabi
TARGET_CPU_VARIANT := generic

# Should be true for devices launched with Pie and Q
TARGET_USES_64_BIT_BINDER := true
9 changes: 9 additions & 0 deletions halium_arm/lineage_halium_arm.mk
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
$(call inherit-product, $(LOCAL_PATH)/../lineage_halium.mk)
# Inherit device
$(call inherit-product, $(LOCAL_PATH)/../device.mk)

PRODUCT_BRAND := halium
PRODUCT_DEVICE := halium_arm
PRODUCT_MANUFACTURER := halium
PRODUCT_NAME := lineage_halium_arm
PRODUCT_MODEL := Generic Device
17 changes: 17 additions & 0 deletions halium_arm64/BoardConfig.mk
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
-include device/halium/halium/BoardConfig.mk

# Include Legacy GSI patches
include build/make/target/board/generic_arm64_ab/BoardConfig.mk

# Architecture
TARGET_ARCH := arm64
TARGET_ARCH_VARIANT := armv8-a
TARGET_CPU_ABI := arm64-v8a
TARGET_CPU_ABI2 :=
TARGET_CPU_VARIANT := generic

TARGET_2ND_ARCH := arm
TARGET_2ND_ARCH_VARIANT := armv8-a
TARGET_2ND_CPU_ABI := armeabi-v7a
TARGET_2ND_CPU_ABI2 := armeabi
TARGET_2ND_CPU_VARIANT := generic
12 changes: 12 additions & 0 deletions halium_arm64/lineage_halium_arm64.mk
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Inherit 64bit configurations
$(call inherit-product, $(SRC_TARGET_DIR)/product/core_64_bit.mk)

# Inherit common files
$(call inherit-product, $(LOCAL_PATH)/../device.mk)
$(call inherit-product, $(LOCAL_PATH)/../lineage_halium.mk)

PRODUCT_BRAND := halium
PRODUCT_DEVICE := halium_arm64
PRODUCT_MANUFACTURER := Halium
PRODUCT_NAME := lineage_halium_arm64
PRODUCT_MODEL := Generic Device
10 changes: 0 additions & 10 deletions lineage_halium_arm64.mk → lineage_halium.mk
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,11 @@
#

# Inherit from those products. Most specific first.
$(call inherit-product, $(SRC_TARGET_DIR)/product/core_64_bit.mk)
# $(call inherit-product, $(SRC_TARGET_DIR)/product/full_base.mk)
$(call inherit-product, $(SRC_TARGET_DIR)/product/product_launched_with_p.mk)

# Inherit halium.mk
$(call inherit-product, vendor/halium/config/halium.mk)

# Inherit device
$(call inherit-product, $(LOCAL_PATH)/device.mk)

# Inherit fonts
$(call inherit-product-if-exists, frameworks/base/data/fonts/fonts.mk)

PRODUCT_BRAND := halium
PRODUCT_DEVICE := halium_arm64
PRODUCT_MANUFACTURER := halium
PRODUCT_NAME := lineage_halium_arm64
PRODUCT_MODEL := Generic Device

0 comments on commit cc07c1e

Please sign in to comment.