fix: improve hires fix efficiency; fix: better SDXL hires fix default implementation; fix: cascade bug (#287) #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tazlin
commented
Jul 21, 2024
tazlin
commented
- See improve hires fix efficiency; fix: better SDXL hires fix default implementation; fix: cascade bug #287 for more information
…ementation; fix: cascade bug (#287) * fix: don't collect custom node stdout ComfyUI uses logger now and all of the emitted messages are captured/handled elsewhere * fix: use latest compat. horde deps * fix: better SDXL hires + calc steps more effectively * fix: resolve bug with cascade steps not applying correctly * tests: group test runs by model within modules This will help minimize the situation where models were loading and unloading an unnecessary number of times * tests: always run cascade tests last * tests: be less likely to download timeout for problem lora * tests: use more threads during CI for lora downloads * tests: add sdxl character hires fix test case * fix: use latest compat. horde deps * style: fix * style: fix typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.