Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no ticket] Initializes logs for db-migrate entry point #3136

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

widal001
Copy link
Collaborator

@widal001 widal001 commented Dec 6, 2024

Summary

Initializes logger for db-migrate entry point which runs as part of the CI/CD pipeline

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

  1. Checkout PR
  2. Run make release-build
  3. Get the image tag from the bottom of the output
  4. Run docker run <image-tag> db-migrate

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

Screenshot 2024-12-06 at 4 34 42 PM

coilysiren
coilysiren previously approved these changes Dec 6, 2024
Comment on lines +64 to +66
# Setup logging
init_logging(__package__)
init_app(logging.root)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is potentially going to make local dev / testing more difficult if you always enable logging as soon as the module loads.

What is the context for this change / where do you want logging that you currently don't have it?

@widal001 widal001 marked this pull request as draft December 9, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants