Fighter Crate Refactor #2317
Merged
Fighter Crate Refactor #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
im sory for the commit spam wuboy please dont take my cheese im literally begging you pleas
King Dedede Crate Refactor
same as tank hopefully i did it right. not complete rn
I completely forgot how to read
…opment/HewDraw-Remix into fighter-crate-refactor
i like this structure more i've decided. matches the style of acmd script packaging
theres no q fighters but im technically not wrong also standardized "null" fns to "stub"
woo
replaces all instances of "agent.lua_state_agent" with the properly defined variable
replaces all instances of `agent.module_accessor` in acmd scripts with a properly defined `boma` variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Organize fighter crates and standardize our naming conventions.
Change the L2CAgentBase local variable from
fightertoagentto match the script dump repository.Move all articles into their own subfolders.
Notes
Do NOT modify a fighter crate that currently has a PR open - we'll do it later when it gets merged into dev.
If you wish to contribute, use Mega Man as a base.
For those who do not have write access to the HDR Repo, you can contribute by making a PR to the
fighter-crate-refactorbranch.Current progress: