Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tex): add has_opaque_alpha for crunch #58

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mklokocka
Copy link
Collaborator

Add a has_opaque_alpha method for the CrunchTexture class. has_alpha built in functions does not account for actual alpha contents, just the validness of the alpha channel.

Use it in format selection.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.97%. Comparing base (025a891) to head (87a13fd).

Files with missing lines Patch % Lines
src/tex/crunch_texture.cpp 80.00% 3 Missing ⚠️
src/tex/optimize.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   78.91%   78.97%   +0.06%     
==========================================
  Files          41       41              
  Lines        1873     1888      +15     
==========================================
+ Hits         1478     1491      +13     
- Misses        395      397       +2     
Files with missing lines Coverage Δ
include/btu/tex/crunch_texture.hpp 100.00% <ø> (ø)
src/tex/optimize.cpp 58.70% <0.00%> (+0.37%) ⬆️
src/tex/crunch_texture.cpp 76.84% <80.00%> (+0.59%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 025a891...87a13fd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant