Further efforts to reproduce loftr hpatches #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More changes related to #20 .
Running
python -m immatch.eval_hpatches --config 'loftr' --task 'both' --rot_dir . --ransac_thres=3 --h_solver cv
now yieldsThese numbers (at 3px) are actually higher than in the LoFTR paper. Take what you find useful from this pull request. I suppose you might want to wait with merging this until there is a reply here: zju3dv/LoFTR#136