Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved the Exit condition and back out condition into the while loop #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions Main.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,18 @@ def App():
newsSourceNumber=raw_input("News Source Number >>>>")
newsSourceNumber=int(newsSourceNumber)

if newsSourceNumber==99:
sys.exit()

if (newsSourceNumber >=len(newsSources)):
print "please select an index less than "+ str(len(newsSources))
else:
sourceNumberOkay = True

except ValueError:
print("That is not a valid News source number")

if newsSourceNumber==99:
sys.exit()


obj=NewsPulling(newsSources[newsSourceNumber])
Articles=obj.BeautifyArticles();
Expand All @@ -51,18 +54,21 @@ def App():
articleNumber=raw_input("Article No >>>>")
articleNumber=int(articleNumber)

if articleNumber==99 :
sys.exit()
if articleNumber==66 :
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will not work as expected.
If the user enters 66 then it will ask a user to select another article but the intention of the user was to go to the main menu to select different news source.
Small fix needed something on the lines of
if article no is 66 or 99 break from the immediate loop and then decide whether to exit or go back to the main menu.

break

if (articleNumber >= len(Articles)):
print "please select an index less than "+ str(len(Articles))
else:
articleNumberOkay = True

except ValueError:
print ("That's not a valid article number")


if articleNumber==99 :
sys.exit()
if articleNumber==66 :
break


#print Articles[articleNumber][2]
extr=ExtractMainContent(newsSources[newsSourceNumber],Articles[articleNumber][2])
Expand Down