make code flake8 complient #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ flake8 *.py ExtractMainContent.py:34:80: E501 line too long (144 > 79 characters) ExtractMainContent.py:48:80: E501 line too long (90 > 79 characters) ExtractMainContent.py:50:80: E501 line too long (90 > 79 characters) ExtractMainContent.py:52:80: E501 line too long (97 > 79 characters) ExtractMainContent.py:55:80: E501 line too long (131 > 79 characters) ExtractMainContent.py:57:80: E501 line too long (101 > 79 characters) Extractor.py:87:80: E501 line too long (84 > 79 characters) Main.py:40:80: E501 line too long (120 > 79 characters) Main.py:59:80: E501 line too long (89 > 79 characters) NewsPulling.py:15:80: E501 line too long (94 > 79 characters) NewsPulling.py:31:80: E501 line too long (113 > 79 characters)
Closed
Griffintaur
reviewed
Oct 7, 2017
| ConfigurationReader.__Limit=cfg['Limit'] | ||
| #print ConfigurationReader.__Limit | ||
| ConfigurationReader.__WebsiteSupported=cfg['WebsiteSupported'] | ||
| #print ConfigurationReader.__WebsiteSupported |
There was a problem hiding this comment.
i dont know about the the pep8 . Can u let me know why the comment has been removed?
Griffintaur
reviewed
Oct 7, 2017
| sys.exit() | ||
| if (newsSourceNumber >=len(newsSources)): | ||
| print ("Please select the index no less than "+ str(len(newsSources))) |
There was a problem hiding this comment.
removing parenthesis from the print doesn't make it compliant only for the python 2.7 while having it makes it work for both python 2.7 and python 3.
There was a problem hiding this comment.
If the aim is to make it compatible between python2 and python3, generally either
- 'from future import print_function' is used
Or - six is made a part of the library. Refer http://six.readthedocs.io/ .
There was a problem hiding this comment.
I think it is is better to go with 'from future import print_function' at this point in time.
|
Sure. Will take care of it in next pull request.
Don't want to take it up in this one.
FWIW, I don't think worrying about python 2 and 3 compatibility is an
issue that should be a point of concern.
Reference:
https://docs.python.org/2/howto/pyporting.html#the-short-explanation
…On Mon, Oct 9, 2017 at 8:55 AM, Ankit Singh ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Main.py
<#19 (comment)>
:
> sys.exit()
- if (newsSourceNumber >=len(newsSources)):
- print ("Please select the index no less than "+ str(len(newsSources)))
I think it is is better to go with 'from future import print_function' at
this point in time.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHZWMeHmcsP9mrcDp19ywXk8sC1TsSwLks5sqZJDgaJpZM4PtFa9>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$ flake8 *.py
ExtractMainContent.py:34:80: E501 line too long (144 > 79 characters)
ExtractMainContent.py:48:80: E501 line too long (90 > 79 characters)
ExtractMainContent.py:50:80: E501 line too long (90 > 79 characters)
ExtractMainContent.py:52:80: E501 line too long (97 > 79 characters)
ExtractMainContent.py:55:80: E501 line too long (131 > 79 characters)
ExtractMainContent.py:57:80: E501 line too long (101 > 79 characters)
Extractor.py:87:80: E501 line too long (84 > 79 characters)
Main.py:40:80: E501 line too long (120 > 79 characters)
Main.py:59:80: E501 line too long (89 > 79 characters)
NewsPulling.py:15:80: E501 line too long (94 > 79 characters)
NewsPulling.py:31:80: E501 line too long (113 > 79 characters)