Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit configuration and autoformat #75

Merged
merged 4 commits into from
Mar 9, 2024
Merged

Conversation

abhidg
Copy link
Contributor

@abhidg abhidg commented Mar 9, 2024

This PR adds pre-commit configuration. I have opted to use ruff as the linter, open to alternatives. Reason for choosing ruff over flake8, black is that it is one tool that combines most Python autoformatting and linting functions in one and is very fast.

@abhidg abhidg changed the title precommit coverage Add pre-commit configuration and autoformat Mar 9, 2024
Copy link
Collaborator

@tlestang tlestang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you beat me to it!! I also went with ruff, so that's a yes for me :) thanks @abhidg

.vscode/settings.json Outdated Show resolved Hide resolved
@abhidg abhidg merged commit fc5fef8 into main Mar 9, 2024
3 checks passed
@ljcolling
Copy link
Contributor

Good choice with Ruff, and it kinda fits with the ethos of the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure pre-commit config
3 participants