-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mock observations model #28
Conversation
Signed-off-by: Paz Barda <[email protected]>
Signed-off-by: Paz Barda <[email protected]>
Signed-off-by: Paz Barda <[email protected]>
@@ -0,0 +1,81 @@ | |||
# Mock Observations Model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR should be opened on official models repo
@@ -0,0 +1,81 @@ | |||
# Mock Observations Model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README should reflect the model is in official models repo
/** | ||
* initialise the generator with the given name and config. | ||
*/ | ||
initialise(name: String, config: {[key: string]: any}): void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check with Asim if we can replace this with a plain ctor
closed PR since mock-observations model is going into the official models repo |
Types of changes
A description of the changes proposed in the Pull Request
MockObservations model generates mock observations for testing and demo purposes